Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal pop-up for the modules page #16

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

Modal pop-up for the modules page #16

wants to merge 19 commits into from

Conversation

sinharitwick
Copy link
Collaborator

No description provided.

shayan-cyber and others added 19 commits August 13, 2022 18:43
@shayan-cyber
bugs-fixed
3e8da4e
@inrittik
profile page added
66cdaac
@inrittik
Merge branch 'main' of https://github.com/NIT-Silchar-Org/tecno-website…
40e80d7 
… into Nrittik-dev
@inrittik
profile page responsiveness and type fixed
f6e2add
@inrittik
merge conflict fixed
096fa1f
@inrittik
updated brochure link
8d42891
@inrittik
fixed section content overlaps
eceabbd
@inrittik
drive link updated
ed09609
@inrittik
fix: issue#7
0e8fa5b
@inrittik
Merge branch 'shayan-dev' of https://github.com/NIT-Silchar-Org/tecno…
532e4a1 
…-website into issue#7
@inrittik
sass setup
6ce5222
@inrittik
sass setup
ebb15de
@inrittik
Merge branch 'dev' of https://github.com/NIT-Silchar-Org/tecno-website …
87816d7 
…into Nrittik-dev
@inrittik
merge conflict resolved
2812fdb
@inrittik
variables added to scss setup
7878588
@inrittik
fixed prettier issue
fd13661
@shayan-cyber
some-changes-modal
32965a3
@sinharitwick
first commit
6cc87dd
@sinharitwick
modal pop-up mobile view
4d02ed8
KaviiSuri
KaviiSuri requested changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@KaviiSuri KaviiSuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take pull from dev and resolve conflicts.
The logic for opening the modal is not implemented.

@KaviiSuri KaviiSuri added the wontfix This will not be worked on label Sep 19, 2022
@aditya2712 aditya2712 added hacktoberfest-accepted and removed wontfix This will not be worked on labels Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaviiSuri KaviiSuri KaviiSuri requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sinharitwick @KaviiSuri @aditya2712 @shayan-cyber @inrittik