Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plot requires labels in demos/0_intro.py #16

Closed
apizzuto opened this issue Apr 28, 2024 · 1 comment · Fixed by #21
Closed

Plot requires labels in demos/0_intro.py #16

apizzuto opened this issue Apr 28, 2024 · 1 comment · Fixed by #21

Comments

@apizzuto
Copy link

Part of openjournals/joss-reviews#6593

Just a tiny nit, but can you please label the Ax1 subplot in the 0_intro.py demo? Looks like the values correspond to (cfm.amplitude(pos_truth)[1:], post_a_mean) but this isn't obvious when looking at the figure.
Edenhofer added a commit that referenced this issue May 10, 2024
@Edenhofer
0_intro.py: Set plot extents and fix spectrum abscissa
6946a87 
Resolves #16 .
@Edenhofer Edenhofer mentioned this issue May 10, 2024
Merged
@Edenhofer
Copy link
Contributor

Edenhofer commented May 10, 2024 •
edited
Loading

Thanks! Right, yeah it is definitely not obvious what this plot shows 🙈

#21 adds labels and tweaks the other plots some more too.

Edenhofer added a commit that referenced this issue May 10, 2024
@Edenhofer
0_intro.py: Set plot extents and fix spectrum abscissa
f30eec0 
Resolves #16 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set plot extents and fix spectrum abscissa in intro demo NIFTy-PPL/NIFTy
2 participants
@Edenhofer @apizzuto