Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.1.4patch #142

Merged
merged 5 commits into from
Nov 15, 2024
Merged

1.1.4patch #142

merged 5 commits into from
Nov 15, 2024

Conversation

sigmafelix
Copy link
Collaborator

  • calculate_hms matches the number of skip_df rows to that of locs when no HMS geometry is found

@sigmafelix
1.1.4patch
0dcba3c 
- process_geos: paths are searched recursively
- skip_merge is getting the explicit `by` argument value
@sigmafelix
calculate_hms fix
b961ac3 
- skip_merge part will result in dimension mismatch error when `from` is character(n)
@mitchellmanware
Copy link
Collaborator

Thanks for these changes, @sigmafelix. Only edit is version number as most recent on CRAN is now 1.1.6.

@mitchellmanware mitchellmanware merged commit 6100c9f into main Nov 15, 2024
10 checks passed
@sigmafelix sigmafelix deleted the 1.1.4patch branch November 19, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchellmanware mitchellmanware mitchellmanware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sigmafelix @mitchellmanware