Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial migration #1

Merged
merged 8 commits into from
Feb 8, 2024
Merged

Initial migration #1

merged 8 commits into from
Feb 8, 2024

Conversation

sigmafelix
Copy link
Collaborator

  • stdt part is included in the migration

Insang Song added 4 commits February 6, 2024 16:06
- Dropped redundant dependencies
- check-standard
- pkgdown config
- indentation fix in DESCRIPTION
- Rds are generated from Roxygen2 documentation
Copy link

codecov bot commented Feb 6, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@sigmafelix
Copy link
Collaborator Author

ARM64 Mac R-CMD-check should fail unless we set another worker with custom-build hdf4. I will remove ARM64 Mac in the next push. Other problems seem to be related to handling read/write privilege in runner images, so I will work on it.

- Added linter
- Removed mac-arm64
- Missing directory separator in Windows runner
@sigmafelix sigmafelix self-assigned this Feb 7, 2024
Insang Song added 3 commits February 8, 2024 13:30
- openssl availability needs to be confirmed in Windows runner
- testthat intermediate outputs do not seem ephemeral: manual removal is enforced
- Missing argument added
@sigmafelix
Copy link
Collaborator Author

Tests passed in Unix-like OSes. I think we should find a Windows machine to look into the errors. What I suspect at the moment about the reason is a missing HDF support in RTools/GDAL driver on Windows.

@sigmafelix sigmafelix merged commit 0b1dbb2 into main Feb 8, 2024
9 of 10 checks passed
@sigmafelix
Copy link
Collaborator Author

@Spatiotemporal-Exposures-and-Toxicology @mitchellmanware
Let's move on to refactor the codebase first. I will look at the errors in Windows with my personal laptop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant