Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packets are being linearized on arrival. #33

Closed
ydahhrk opened this issue May 9, 2013 · 1 comment
Closed

Packets are being linearized on arrival. #33

ydahhrk opened this issue May 9, 2013 · 1 comment
Assignees
Milestone

Comments

@ydahhrk
Copy link
Member

ydahhrk commented May 9, 2013

Test case ID: N/A
Date: 2013/05/09
OS: N/A
Tester: AL
Error module: core.

Description: Packet linearization: http://vger.kernel.org/~davem/skb_data.html.
This doesn't affect functionality at all; it will simply introduce some performance penalty if people gets paged packets.

Observations: It hasn't been addressed because it appears to me the "two helper routines available which make this pretty easy" don't really buy me anything when packets contain IPv4 options or IPv6 extension headers (Eg. how do I know how many bytes do I need to ask to get the layer 4 header's protocol of a IPv6 packet?).
Am I missing something?

@ghost ghost assigned ydahhrk May 9, 2013
@ydahhrk
Copy link
Member Author

ydahhrk commented Nov 13, 2014

The kernel's IPv4 defragmenter (on kernels 3.13+) accomplishes its task by pretending fragments are pages. Because paging is what linearizing undoes, #41 most likely depends on this.

Adding to the 3.3.0 milestone.

@ydahhrk ydahhrk self-assigned this Nov 13, 2014
@ydahhrk ydahhrk added this to the 3.3.0 milestone Nov 13, 2014
ydahhrk added a commit that referenced this issue Dec 11, 2014
This is necessary so NAT64 happens after iptables does filtering.
It's also needed so Jool catches local traffic, which is needed by local CLATs.
As an added bonus, it invalidates issue #90. Woot!

Progress so far, summary:
- Issue #33: Done.
- Issue #41: Done.
- Issue #107: Done.
- Issue #111: dhfelix is done, but haven't even started to review.
- Issue #116: EAM done, moved from prerouting done, dummy interface done. Missing (off the top of my head):
	- Adapting the global packet processing pipeline for stateless mode.
	- Configuration options.
	- Review RFC 6145 and updaters.
- Issue #120: Done.
- Issue #121: Not done.

Everything needs testing. There are known bugs with fragmentation.
@ydahhrk ydahhrk closed this as completed Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant