Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain sk_buffs are not being released from memory #109

Closed
ydahhrk opened this issue Sep 8, 2014 · 0 comments
Closed

Certain sk_buffs are not being released from memory #109

ydahhrk opened this issue Sep 8, 2014 · 0 comments
Assignees
@ydahhrk
Milestone
3.2.1

Comments

@ydahhrk
Copy link
Member

ydahhrk commented Sep 8, 2014

We have a memory leak in the core module.

When there is fragmentation involved, sk_buffs are queued. When translation is successful, Jool asks the kernel to drop the packet. Because the kernel doesn't know the sk_buffs are queued, it only frees the first one.

This is that one bug that only applies to 3.2.0. It does not apply to the 3.1 series.
@ydahhrk ydahhrk self-assigned this Sep 8, 2014
@ydahhrk ydahhrk added this to the 3.2.1 milestone Sep 8, 2014
ydahhrk added a commit that referenced this issue Sep 15, 2014
@ydahhrk
Issue #109.
66a09f0 
By testing the checksums again, I realized that there's no reason to not update inner packet checksums anymore, and wireshark would judge Jool's packets better if we do.
Therefore, I'm going to refactor Translate a bit again. Checkpoint.
ydahhrk added a commit that referenced this issue Oct 8, 2014
@ydahhrk
Merging version 3.2.1 into master, hereby makingthe changes official.
3025ec2 
Version 3.2.1 is 3.2.0 with issues #57, #106, #108 and #109 fixed.
Issue #107 has been marked as duplicate and postponed to 3.3.0.

rting with '#' will be ignored, and an empty message aborts
@ydahhrk ydahhrk closed this as completed Oct 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ydahhrk ydahhrk

Labels
None yet
Projects
None yet
Milestone
3.2.1
Development

No branches or pull requests
1 participant
@ydahhrk