Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/exchange #108

Merged
merged 158 commits into from
Dec 30, 2024
Merged

Feature/exchange #108

merged 158 commits into from
Dec 30, 2024

Conversation

tomaspalma
Copy link
Member

@tomaspalma tomaspalma commented Sep 5, 2024 •
edited
Loading

This PR puts the beta version of exchange into develop

Main currently implemented features

  • Federated authentication

  • Implemented endpoints to submit, view and verify an exchange

tomaspalma and others added 30 commits February 24, 2024 15:21
@tomaspalma
feature: login endpoint authenticating with sigarra
637ac44
@tomaspalma
fix: session cookies are now created with correct attributes
3dc9b82
@tomaspalma
Merge pull request #1 from tomaspalma/feature/sigarra-auth
1565c79 
Feature/sigarra auth
@joaonevesf @pfpo
started student schedule route
a7a384f 
Co-authored-by: Pedro Oliveira <[email protected]>
@joaonevesf
student_schedule request working
b072f0b
@tomaspalma
add: schema for direct exchange and started api to submit exchange
2dbf74a
@tomaspalma
feat: verifying an exchange is now working
4266230
@tomaspalma
add: jwt key is now from env file or from os env var
0b5bb33
@tomaspalma
feat: when creating exchange request, the exchange id is now not harc…
fd97fac 
…oded
@joaonevesf @pfpo
added get for course schedules on sigarra
7ce080c 
Co-authored-by: Pedro Oliveira <[email protected]>
@tomaspalma
feat: checking for overlaps and if students belong to classes to exch…
d58905e 
…ange
@tomaspalma
add: exchange confirmation jwt expiration date
9cd2313
@tomaspalma
fix: undeclared variable
a9e5f33
@tomaspalma
Merge pull request #2 from tomaspalma/feature/accept-exchange-code-ge…
bd05f39 
…neration

Initial version of direct exchange backend validation
@tomaspalma
fix: class overlap bugs
7c868fd
@pfpo
now fetching UC name from db
9c52fd9
@tomaspalma
fix: direct exchange was not added correctly for the auth user
8331a14
@pfpo
Merge branch 'develop' into feature/student-schedule
32e61a0
@pfpo
moved function to utils
ecef785
@tomaspalma
fix: import corrected
07c27fa
@joaonevesf
fixed: api not sending 403 status
7b991ae
@joaonevesf
Merge pull request #7 from tomaspalma/feature/student-schedule
f20216c 
student courses and units are now being fetched from sigarra API
@tomaspalma
Merge branch 'develop' into feature/accept-exchange-code-generation
fddd046
@tomaspalma
fix: return json indicating success to frontend
ced7671
@tomaspalma
Merge pull request #5 from tomaspalma/feature/accept-exchange-code-ge…
fc2efd5 
…neration

Fixed overlap checking bugs
@joaonevesf
logout now deletes backend session
da66ee0
@tomaspalma @joaonevesf
fix: class overlap bugs
dfe9918
@tomaspalma @joaonevesf
fix: direct exchange was not added correctly for the auth user
d3ccb90
@tomaspalma @joaonevesf
fix: return json indicating success to frontend
d79b9c4
@tomaspalma
fix: overlap checking only after student schedules are totally changed
dec14ed
@tomaspalma tomaspalma marked this pull request as ready for review November 30, 2024 00:45
@tomaspalma tomaspalma requested a review from a team December 3, 2024 21:12
thePeras
thePeras reviewed Dec 13, 2024
View reviewed changes
django/tts_be/settings.py Outdated Show resolved Hide resolved
django/tts_be/settings.py Outdated Show resolved Hide resolved
django/tts_be/settings.py Outdated Show resolved Hide resolved
django/tts_be/settings.py Outdated Show resolved Hide resolved
django/tts_be/settings.py Outdated Show resolved Hide resolved
django/university/routes/MarketplaceExchangeView.py Show resolved Hide resolved
django/university/routes/auth/InfoView.py Outdated Show resolved Hide resolved
django/university/routes/exchange/DirectExchangeView.py Show resolved Hide resolved
django/university/views.py Outdated Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
thePeras
thePeras reviewed Dec 28, 2024
View reviewed changes
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, including mailpit to see emails!

django/university/exchange/utils.py Outdated Show resolved Hide resolved
@tomaspalma tomaspalma mentioned this pull request Dec 30, 2024
Closed
thePeras
thePeras approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 🛫

@tomaspalma tomaspalma merged commit 7d8a98d into develop Dec 30, 2024
@tomaspalma tomaspalma deleted the feature/exchange branch December 30, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePeras thePeras thePeras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tomaspalma @thePeras @joaonevesf @pfpo @eduardooliveiraps @jose-carlos-sousa