Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better script running #194

Merged
merged 7 commits into from
Nov 11, 2024
Merged

Better script running #194

merged 7 commits into from
Nov 11, 2024

Conversation

toni-santos
Copy link
Collaborator

Closes #188

@toni-santos toni-santos self-assigned this Oct 7, 2024
@toni-santos toni-santos marked this pull request as ready for review October 8, 2024 17:49
thePeras
thePeras requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this! It makes it easier to know what is being run on a certain page.

Some pages I have tested are not passing the regex test. Can you look into that?

content-scripts/index.ts Outdated Show resolved Hide resolved
content-scripts/index.ts Outdated Show resolved Hide resolved
content-scripts/index.ts Outdated Show resolved Hide resolved
content-scripts/index.ts Outdated Show resolved Hide resolved
@toni-santos
Copy link
Collaborator Author

I really like this! It makes it easier to know what is being run on a certain page.

Some pages I have tested are not passing the regex test. Can you look into that?

Are you able to track down what page that occured in? I'll double check the regexs ASAP still

@toni-santos toni-santos requested a review from thePeras November 6, 2024 18:08
thePeras
thePeras previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets goo! ✅ 🛫

@toni-santos toni-santos force-pushed the feature/better-script-running branch from cddbecd to 2e969df Compare November 10, 2024 15:39
@toni-santos toni-santos requested a review from thePeras November 10, 2024 15:41
@toni-santos toni-santos merged commit 9313040 into develop Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePeras thePeras thePeras approved these changes

@SimaoNery SimaoNery Awaiting requested review from SimaoNery

Assignees

@toni-santos toni-santos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better page script running
2 participants
@toni-santos @thePeras