Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added linter and formatter #189

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Added linter and formatter #189

merged 3 commits into from
Sep 25, 2024

Conversation

toni-santos
Copy link
Collaborator

Closes #20
Add eslint and prettier

@toni-santos toni-santos self-assigned this Sep 11, 2024
@toni-santos
Copy link
Collaborator Author

toni-santos commented Sep 11, 2024

I have not yet touched on the popup's files prettier and eslint configs, seeing as it would be pretty cumbersome to have 2 (perhaps different) instances of these tools affect the code in different ways. Those files have been however formatted/linted according to the rules introduced in this PR.
Proper testing for this PR is also important so it would be good to have multiple people actively hunting for issues introduced by tweaking so much code.

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested the core features and nothing is broken!

Don't forget to

  • Commit a recent formatted version (package.json is unformatted)
  • Delete the popup settings
  • Update the readme with the new scripts commands

What you think to add this to readme?

.vscode/settings.json
{
    "editor.formatOnSave": true,
    "editor.defaultFormatter": "esbenp.prettier-vscode"
}

So people automatically format on save using the added formatter.

thePeras
thePeras previously approved these changes Sep 15, 2024
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing the conflicts, ready to go! ✅ 🛫

@thePeras
Copy link
Member

To setup the action we can check TTS PR.
An important aspect is to make it running only on ready PRs and ignore Drafs!

@toni-santos toni-santos merged commit 24ebe74 into develop Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a linter and formatter
2 participants