-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added linter and formatter #189
Conversation
I have not yet touched on the popup's files prettier and eslint configs, seeing as it would be pretty cumbersome to have 2 (perhaps different) instances of these tools affect the code in different ways. Those files have been however formatted/linted according to the rules introduced in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tested the core features and nothing is broken!
Don't forget to
- Commit a recent formatted version (package.json is unformatted)
- Delete the popup settings
- Update the readme with the new scripts commands
What you think to add this to readme?
.vscode/settings.json
{
"editor.formatOnSave": true,
"editor.defaultFormatter": "esbenp.prettier-vscode"
}
So people automatically format on save using the added formatter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fixing the conflicts, ready to go! ✅ 🛫
To setup the action we can check TTS PR. |
Closes #20
Add eslint and prettier