Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Layout to use tsx #178

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Refactor Layout to use tsx #178

merged 3 commits into from
Sep 5, 2024

Conversation

thePeras
Copy link
Member

@thePeras thePeras commented Aug 10, 2024 •
edited
Loading

Closes #176

@thePeras thePeras marked this pull request as ready for review August 22, 2024 17:28
@thePeras thePeras force-pushed the refactor/layout-to-tsx branch from 55c3962 to 6ace68e Compare August 22, 2024 17:30
toni-santos
toni-santos requested changes Aug 23, 2024
View reviewed changes
content-scripts/components/HeaderLinks.tsx Show resolved Hide resolved
content-scripts/components/Button.tsx Outdated Show resolved Hide resolved
content-scripts/modules/layout.ts Outdated Show resolved Hide resolved
content-scripts/modules/utilities/popover.js Outdated Show resolved Hide resolved
content-scripts/components/HeaderAuthentication.tsx Show resolved Hide resolved
content-scripts/components/HeaderAuthentication.tsx Outdated Show resolved Hide resolved
@thePeras thePeras requested a review from toni-santos August 23, 2024 16:42
@toni-santos toni-santos mentioned this pull request Sep 2, 2024
Closed
toni-santos
toni-santos requested changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@toni-santos toni-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to merge right now, just need to address the bug mentioned in the discussion of the previous review 👍

@thePeras thePeras force-pushed the refactor/layout-to-tsx branch from f114c9b to 0de0741 Compare September 2, 2024 18:32
@thePeras thePeras force-pushed the refactor/layout-to-tsx branch from 0de0741 to 8074588 Compare September 4, 2024 14:23
@thePeras thePeras requested a review from toni-santos September 4, 2024 14:23
toni-santos
toni-santos approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@toni-santos toni-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thePeras thePeras merged commit 72f72b3 into develop Sep 5, 2024
@thePeras thePeras deleted the refactor/layout-to-tsx branch September 5, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toni-santos toni-santos toni-santos approved these changes

@TomasdosBeefs TomasdosBeefs Awaiting requested review from TomasdosBeefs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor layout.js into layout.tsx
2 participants
@thePeras @toni-santos