Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AEA-3534 Modify Spine client code so that it doesn't call Spine if the Certificate is not configured #166

Merged
merged 12 commits into from
Sep 26, 2023
Merged

AEA-3534 Modify Spine client code so that it doesn't call Spine if the Certificate is not configured #166

merged 12 commits into from
Sep 26, 2023

Conversation

kris-szlapa
Copy link
Contributor

Summary

  • ❗ Breaking Change
  • ⚠️ Potential issues that might be caused by this change

Details

Modify Spine client code so that it doesn't call Spine if the Certificate is not configured

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the jira ticket has been updated with the github pull request link

@github-actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

AEA-3534

@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 21, 2023 11:38 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 21, 2023 11:38 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 22, 2023 15:11 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 22, 2023 15:11 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 24, 2023 20:02 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 24, 2023 20:02 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 25, 2023 12:50 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 25, 2023 12:50 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 25, 2023 15:39 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 25, 2023 15:39 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 25, 2023 16:15 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 25, 2023 16:15 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 25, 2023 16:30 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 25, 2023 16:30 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 25, 2023 22:06 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 25, 2023 22:06 — with GitHub Actions Inactive
anthony-nhs
anthony-nhs reviewed Sep 26, 2023
View reviewed changes
packages/spineClient/src/live-spine-client.ts Outdated Show resolved Hide resolved
packages/getMyPrescriptions/src/getMyPrescriptions.ts Outdated Show resolved Hide resolved
packages/spineClient/src/sandbox-spine-client.ts Outdated Show resolved Hide resolved
packages/spineClient/src/spine-client.ts Outdated Show resolved Hide resolved
packages/statusLambda/src/statusLambda.ts Outdated Show resolved Hide resolved
packages/statusLambda/tests/test-handler.test.ts Show resolved Hide resolved
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 26, 2023 08:28 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 26, 2023 08:28 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 26, 2023 09:37 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 26, 2023 09:37 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.3% 87.3% Coverage
2.2% 2.2% Duplication

@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 26, 2023 10:28 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa temporarily deployed to dev-pr September 26, 2023 10:28 — with GitHub Actions Inactive
@kris-szlapa kris-szlapa enabled auto-merge (squash) September 26, 2023 10:33
@anthony-nhs anthony-nhs merged commit 9ffc61a into main Sep 26, 2023
8 checks passed
@anthony-nhs anthony-nhs deleted the AEA-3534-modify-spine-client-code-for-not-configured-certificate branch September 26, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-nhs anthony-nhs anthony-nhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kris-szlapa @anthony-nhs