Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from PyMongo ssl config to tls config #190

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

adrianclay
Copy link
Collaborator

@adrianclay adrianclay commented Aug 21, 2024

Why

PyMongo 4 changed how this config should be specified.

https://pymongo.readthedocs.io/en/4.8.0/examples/tls.html

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

@adrianclay
Copy link
Collaborator Author

PR #159 would have caught this defect if it were merged, as it fails the build if the Adaptors are unable to boot up.

@adrianclay adrianclay marked this pull request as ready for review August 29, 2024 16:13
@adrianclay adrianclay enabled auto-merge (squash) August 29, 2024 16:13
@adrianclay adrianclay merged commit 882af9e into main Sep 2, 2024
1 check passed
@adrianclay adrianclay deleted the fix-ssl-pymongo-error branch September 2, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants