Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blank versions from setup.py #176

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

adrianclay
Copy link
Collaborator

Why

In Python 3.8 this blank version value causes setuptools to throw an error

setuptools.extern.packaging.version.InvalidVersion: Invalid version: ''

Type of change

Internal change (non-breaking change with no effect on the functionality affecting end users)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

In Python 3.8 this blank version value causes setuptools to throw an error

> setuptools.extern.packaging.version.InvalidVersion: Invalid version: ''
@adrianclay adrianclay enabled auto-merge (squash) August 9, 2024 15:31
@adrianclay adrianclay merged commit 4812277 into main Aug 9, 2024
1 check passed
@adrianclay adrianclay deleted the remove-blank-version branch August 9, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants