Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error logging for each attachment #156

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Remove error logging for each attachment #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Fix rare issue where GP2GP Large Message compressed fragments were being corrupted by the inbound adaptor.
- Removed logging of "Attachment IDs: ..." at ERROR level.
This appears to have been accidentally added, and is not an actual error but rather debugging information.

## [1.3.1] - 2023-11-22

### Fixed

- Removed logging of inbound request data at ERROR level.
This appears to have been accidently added in version 1.2.4 as part of debugging, but has the side effect of duplicating request data in the logs.
This appears to have been accidentally added in version 1.2.4 as part of debugging, but has the side effect of duplicating request data in the logs.
This additional log was erroneously output at ERROR level, and slows down the adaptor.

## [1.3.0] - 2023-10-23
Expand Down
3 changes: 0 additions & 3 deletions mhs/common/mhs_common/messages/ebxml_envelope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,6 @@ def parse_attachments(xml_tree: Element, attachment_payloads) -> Dict[str, str]:
# grab the existing payload item by cid
foundPayload = next((item for item in attachment_payloads if item[ATTACHMENT_CONTENT_ID] == cid), None)

for item in attachment_payloads:
logger.error("Attachment IDs:" + item[ATTACHMENT_CONTENT_ID])

# We may have already decompressed a compressed payload or converted from base64, if so,
# update the payload description fields with the correct details and form our attachment
# All this to add the description field :)
Expand Down