add fix to split to handle an equal sign in the filename.

NHSDigital · Dec 11, 2024 · 70512f1 · 70512f1
1 parent 87b87bf
commit 70512f1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/mhs/common/mhs_common/messages/ebxml_envelope.py b/mhs/common/mhs_common/messages/ebxml_envelope.py
@@ -228,7 +228,7 @@ def parse_external_attachments(xml_tree: Element) -> Dict[str, str]:
 
                     filename = None
                     print(variables)
-                    description_variables = dict(pair.split("=") for pair in variables)
+                    description_variables = dict(pair.split("=", 1) for pair in variables)
                     if "Filename" in description_variables:
                         filename = description_variables["Filename"].replace('\\', '')
 

diff --git a/mhs/common/mhs_common/messages/tests/test_ebxml_envelope.py b/mhs/common/mhs_common/messages/tests/test_ebxml_envelope.py
@@ -51,7 +51,5 @@ def test_filename_contains_equals_sign(self):
         )
         xml_tree = ElementTree.fromstring(message)
 
-        external_attachments = ebxml_envelope.EbxmlEnvelope.parse_external_attachments(xml_tree)
-        print("MartinTest")
-        print(external_attachments.keys())
+        external_attachments = ebxml_envelope.EbxmlEnvelope.parse_external_attachments(xml_tree)["external_attachments"]
         self.assertEqual(external_attachments, {})