NIAD 3217 - Fix duplicated Test Results

[Alex-Nita]

What

Changed DiagnosticReportMapper to not send duplicated Test Reports to SpecimenMapper

Why

Duplicated test reports were appearing in the generated xml.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Internal change (non-breaking change with no effect on the functionality affecting end users)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I have performed a self-review of my code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

[Alex-Nita]

Apologies to the reviewer - The existing file was very poorly formatted making any changes very hard to make. You can find the actual difference in values here: b298406#diff-985e27182cd9375e604dc2c64df1af502c7df8e6d2bffbdcc3ef454d88df22d4

[Alex-Nita]

This change was made because the Observation referenced had a specimen referenced that was NOT included in the diagnostic report. The new referenced observation had no specimen referenced at all (Which is what the test is intended to test).

[Alex-Nita]

Observation used for this test was changed, see comment

[github-actions]

• Surviving mutants in this change: 1
• Killed mutants in this change: 4

class	surviving	killed
🧟uk.nhs.adaptors.gp2gp.ehr.mapper.diagnosticreport.DiagnosticReportMapper	1	4

See https://pitest.org

• Arcmutate licence valid until 2026-07-16 (yyyy/mm/dd) (non-commercial use only)
• Project uses Spring, but the Arcmutate Spring plugin is not present.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud