Code Quality: Replace deprecated constructor call and fix unchecked assignment warning #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssignment warning Code Quality fix to replace deprecated constructors on `URL(java.lang.String) with the recommended `URI().toURL()` method instead Fix waring with "Warning:(42, 16) Unchecked assignment: 'java.util.HashMap' to 'java.util.Map<java.lang.String,java.lang.Object>'"
|
Looks good. No mutations were possible for these changes. |
|
MartinWheelerMT
commented
Nov 21, 2024
| @@ -37,7 +38,7 @@ public Map<String, Object> patient(String nhsNumber) throws Exception { | |||
|
|
|||
| String patientData = getPatientData(nhsNumber, accessToken); | |||
|
|
|||
| return new ObjectMapper().readValue(patientData, HashMap.class); | |||
| return new ObjectMapper().readValue(patientData, new TypeReference<>() {}); | |||
There was a problem hiding this comment.
The part which is new TypeReference<>() {} is actually new TypeReference<Map<String, Object>>() {} but you can omit the Map<String, Object>> if it can be inferred.
This is a way to provide full type information to Jackson when deserializing, avoiding unchecked warnings. It's a generic safe way to tell the object mapper what it is being deserialized into
adrianclay
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
URL(java.lang.String) with the recommendedURI().toURL()` method insteadWhy
Deprecate URL public constructors
Warning: Unchecked assignment: 'java.util.HashMap' to 'java.util.Map<java.lang.String,java.lang.Object>'
Type of change
Please delete options that are not relevant.
Checklist: