Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup: removing unused code variables, excessing throwables and making test assessments more concise #920

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

ole4ryb
Copy link
Contributor

@ole4ryb ole4ryb commented Nov 8, 2024

What

Code cleanup

Why

There are a lot of unused variables or even whole methods, excessive throwable declarations against test methods that need to be cleanup as they don't provide any value to the code but even clutter it hence need to be removed.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users
  • A corresponding change has been made to the Mapping Documentation repository

@ole4ryb ole4ryb marked this pull request as ready for review November 8, 2024 16:36
@ole4ryb ole4ryb requested a review from adrianclay November 11, 2024 13:37
@ole4ryb ole4ryb merged commit 7fd01e9 into main Nov 11, 2024
1 check passed
@ole4ryb ole4ryb deleted the code-cleanup branch November 11, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants