Refactor unit tests in MedicationRequestMapperTests to use nested classes.
#869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWheelerMT
force-pushed
the
refactor-medication-request-mapper-tests
branch
from
ce439a8 to
5922501
Compare
…lassed for the grouped tests for `acute` and `repeat` when two `ehrSupplyPrescribe` reference one `ehrSupplyAuthorise`.
MartinWheelerMT
force-pushed
the
refactor-medication-request-mapper-tests
branch
from
5922501 to
a84c330
Compare
adrianclay
reviewed
Oct 10, 2024
Comment on lines
+372
to
+373
| @DisplayName("WhenTwoEhrSupplyPrescribeReferenceOneRepeatEhrSupplyAuthorise") | ||
| class TwoEhrSupplyPrescribeReferenceOneRepeatEhrSupplyAuthorise { |
There was a problem hiding this comment.
Given that the display is only 4 characters different to the class name, what was the thinking for using DisplayName?
adrianclay
reviewed
Oct 10, 2024
| ); | ||
| } | ||
| assertAll( | ||
| () -> assertThat(planMedicationRequests).as("Plans").hasSize(1), |
There was a problem hiding this comment.
This as is new to me. Like a whole new junit.
adrianclay
reviewed
Oct 10, 2024
| .mapResources(ehrExtract, (Patient) new Patient().setId(PATIENT_ID), List.of(), PRACTISE_CODE); | ||
| @Nested() | ||
| @DisplayName("WhenTwoEhrSupplyPrescribeReferenceOneAcuteEhrSupplyAuthorise") | ||
| class TwoEhrSupplyPrescribeReferenceOneAcuteEhrSupplyAuthorise { |
There was a problem hiding this comment.
Similar DisplayName thing here, but it's not major.
adrianclay
approved these changes
Oct 10, 2024
adrianclay
reviewed
Oct 10, 2024
Comment on lines
+377
to
+387
| @BeforeAll | ||
| static void beforeAll() { | ||
| ehrExtract = unmarshallEhrExtract( | ||
| "ehrExtract_MultipleSupplyPrescribeInFulfilmentOfSingleNonAcuteSupplyAuthorise.xml" | ||
| ); | ||
| } | ||
|
|
||
| var earliestOrder = getMedicationRequestById(resources, EARLIEST_ORDER_ID); | ||
| @BeforeEach | ||
| void beforeEach() { | ||
| setupMultipleOrdersToOnePlanStubs(REPEAT_PRESCRIPTION_EXTENSION); | ||
| } |
There was a problem hiding this comment.
Very minor, but I've never really understood the benefit of beforeAll, unless the setup is actually very slow and there is a performance benefit. Otherwise it just mildly hampers the readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactor unit tests in
MedicationRequestMapperTeststo use nested classes for the grouped tests foracuteandrepeatwhen twoehrSupplyPrescribereference oneehrSupplyAuthorise.Why
Refactoring to group similar tests into nested test classes for readability and to allow more descriptive test names
Type of change
Please delete options that are not relevant.
Checklist: