Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where IntelliJ reports an assertion issue in the SpecimenCompoundsMapper #847

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

MartinWheelerMT
Copy link
Collaborator

@MartinWheelerMT MartinWheelerMT commented Oct 1, 2024

What

Fix issue with IntelliJ reporting a problem with isEqualTo when comparing the actual in the assertation to the expected valued in the isEqualTo

Why

IntelliJ reports a problem with isEqualTo when comparing the actual in the assertation to the expected valued in the isEqualTo. This is not a java problem but will prevent IntelliJ displaying a yellow waring.

The IntelliJ warning is:

'isEqualTo()' between objects of inconvertible types 'List<RCMRMT030101UKCompoundStatement>' and 'List<String>' 

Type of change

Please delete options that are not relevant.

  • Internal change (non-breaking change with no effect on the functionality affecting end users)

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Fix issue with incorrect usage of isEqualTo when comparing lists in SpecimenBatteryMapperTest.
@MartinWheelerMT MartinWheelerMT enabled auto-merge (squash) October 1, 2024 15:29
@MartinWheelerMT MartinWheelerMT changed the title Fix issue with incorrect usage of isEqualTo Fix issue where IntelliJ reports an assertion issue in the SpecimenCompoundsMapper Oct 2, 2024
@MartinWheelerMT MartinWheelerMT enabled auto-merge (squash) October 2, 2024 09:56
@MartinWheelerMT MartinWheelerMT merged commit 0a66835 into main Oct 2, 2024
1 check passed
@MartinWheelerMT MartinWheelerMT deleted the fix-issue-with-incorrect-usage-of-isEqualTo branch October 2, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants