NIAD-2671: Output dead letter message at INFO level #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the event that an MHS inbound message cannot be processed it would be useful to be clear what happens to the message once the error happens. By outputing this at DEBUG level this message wouldn't have beeen displayed in a production like environment, making it harder for the NME to know what's happened to the corrupt message.
ole4ryb
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In the event that an MHS inbound message cannot be processed it would be useful to be clear what happens to the message once the error happens.
By outputing this at DEBUG level this message wouldn't have been displayed in a production like environment, making it harder for the NME to know what's happened to the corrupt message.
Type of change
Bug fix (non-breaking change which fixes an issue)
Checklist: