-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POST NIAD-3114 refactoring: Refactor meta security assertions #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianclay
reviewed
Aug 21, 2024
gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/util/MetaFactoryUtil.java
Outdated
Show resolved
Hide resolved
martin-nhs
reviewed
Aug 22, 2024
gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/util/MetaFactoryUtil.java
Outdated
Show resolved
Hide resolved
martin-nhs
reviewed
Aug 22, 2024
...t/java/uk/nhs/adaptors/pss/translator/mapper/medication/MedicationRequestPlanMapperTest.java
Show resolved
Hide resolved
martin-nhs
reviewed
Aug 22, 2024
...anslator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/ProcedureRequestMapperTest.java
Outdated
Show resolved
Hide resolved
martin-nhs
reviewed
Aug 22, 2024
...anslator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/ProcedureRequestMapperTest.java
Outdated
Show resolved
Hide resolved
martin-nhs
reviewed
Aug 22, 2024
gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/ObservationMapperTest.java
Outdated
Show resolved
Hide resolved
martin-nhs
reviewed
Aug 22, 2024
gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/EncounterMapperTest.java
Outdated
Show resolved
Hide resolved
martin-nhs
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactoring meta security assertions
Why
Meta security assertions consisted of quite a few lines of code and was used in different classes. This can be moved into a utility class and reused. Also, meta security assertion was optimized as well to reduce the amount of code.
Type of change
Please delete options that are not relevant.
Checklist: