NIAD-3145: PS Adaptor should reject request with an invalid ConversationId header
#781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Unit Tests to ensure that `Bad Request` operational outcomes are returned when an invalid `ConversationId` is provided. Add package-info.java to resolve warnings around @NonNullApi Update ConversationIdFilter to return `Bad Request` operational outcomes are returned when an invalid `ConversationId` is provided. Update README.md to document updated response
MartinWheelerMT
commented
Aug 20, 2024
There was a problem hiding this comment.
This has been added to prevent compiler warnings around @NonNullApi missing from overridden method parameters.
Previously this was using the same random UUID when running the whole testsuite. There is no need for this test to use an actually random UUID, so just hardcode it to reduce the complexity of the test.
Previously this UUID static mock was affecting all tests which ran after it as the "close" method was never being called. Instead move into a separate method where its blast area is a lot smaller.
adrianclay
approved these changes
Aug 22, 2024
MartinWheelerMT
deleted the
niad-3145-reject-request-with-invalid-conversation-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
*Create Unit Tests for ConversationIdFilter
Bad Requestoperational outcomes are returned when an invalidConversationIdis provided.Bad Requestoperational outcomes are returned when an invalidConversationIdis provided.Why
Currently the GPC Facade endpoint will accept
ConversationIdheaders, where the value is populated but with a value is not a valid UUID.When given an invalid argument, or missing argument which is required the adaptor should be returning a 400 Bad Request HTTP Error.
This should provide the
OperationalOutcomein the content (as specified by GP Connect) detailing the error which has occurred.Type of change
Please delete options that are not relevant.
Checklist: