-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIAD-3148 - Immunizations outside of consultation are mapped to Observation #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the description ID and concept ID
…nceptOrDescriptionId`
martin-nhs
commented
Aug 8, 2024
gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/TestUtility.java
Outdated
Show resolved
Hide resolved
martin-nhs
commented
Aug 8, 2024
gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/TestUtility.java
Show resolved
Hide resolved
martin-nhs
commented
Aug 8, 2024
gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/TestUtility.java
Show resolved
Hide resolved
martin-nhs
commented
Aug 8, 2024
...r/src/integrationTest/java/uk/nhs/adaptors/pss/translator/DatabaseImmunizationCheckerIT.java
Outdated
Show resolved
Hide resolved
martin-nhs
commented
Aug 8, 2024
...r/src/integrationTest/java/uk/nhs/adaptors/pss/translator/DatabaseImmunizationCheckerIT.java
Outdated
Show resolved
Hide resolved
martin-nhs
commented
Aug 8, 2024
db-connector/src/main/java/uk/nhs/adaptors/connector/dao/ImmunizationSnomedCTDao.java
Outdated
Show resolved
Hide resolved
martin-nhs
commented
Aug 9, 2024
db-connector/src/main/java/uk/nhs/adaptors/connector/dao/ImmunizationSnomedCTDao.java
Outdated
Show resolved
Hide resolved
adrianclay
reviewed
Aug 10, 2024
…nvironment variable is not present, it will display a summary of all variables not present, saving time.
adrianclay
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR resolves a bug where an immunization was incorrectly mapped to an Observation due to a SNOMED code mismatch. During debugging, it was identified that the code being processed was a
Description ID
rather than aConcept ID
, which caused the mapping error. To address this, the immunization codes view has been modified to include a join on theDescription ID
. This update allows for accurate querying and validation, ensuring the correct mapping of immunization data.Why
More details can be found on the ticket.
Type of change
Checklist: