Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIAD-3148 - Immunizations outside of consultation are mapped to Observation #752

Merged
merged 20 commits into from
Aug 12, 2024

Conversation

martin-nhs
Copy link
Contributor

@martin-nhs martin-nhs commented Aug 8, 2024

What

This PR resolves a bug where an immunization was incorrectly mapped to an Observation due to a SNOMED code mismatch. During debugging, it was identified that the code being processed was a Description ID rather than a Concept ID, which caused the mapping error. To address this, the immunization codes view has been modified to include a join on the Description ID. This update allows for accurate querying and validation, ensuring the correct mapping of immunization data.

Why

More details can be found on the ticket.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users
  • A corresponding change has been made to the Mapping Documentation repository

@martin-nhs martin-nhs marked this pull request as draft August 8, 2024 12:35
@martin-nhs martin-nhs marked this pull request as ready for review August 9, 2024 15:36
@martin-nhs martin-nhs enabled auto-merge (squash) August 9, 2024 15:51
@martin-nhs martin-nhs merged commit fccd428 into main Aug 12, 2024
1 check passed
@martin-nhs martin-nhs deleted the NIAD-3148 branch August 12, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants