[NIAD-3131] Add ConfidentialityCode support for Conditions
#735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntly added test pass
…lityCode is at ehrComposition level, NOPAT meta security is still added. Refactors to ConditionMapper.java
martin-nhs
commented
Aug 1, 2024
Comment on lines
+84
to
+87
| static final String NAMED_STATEMENT_REF_ID = "NAMED_STATEMENT_REF_ID"; | ||
| static final String STATEMENT_REF_ID = "STATEMENT_REF_ID"; | ||
| static final String STATEMENT_REF_ID_1 = "STATEMENT_REF_ID_1"; | ||
| static final int EXPECTED_NUMBER_OF_EXTENSIONS = 4; |
There was a problem hiding this comment.
These likely can be private.
adrianclay
reviewed
Aug 1, 2024
gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/ConditionMapperTest.java
Outdated
Show resolved
Hide resolved
adrianclay
reviewed
Aug 1, 2024
Comment on lines
316
to
318
| when(dateTimeMapper.mapDateTime( | ||
| any(String.class) | ||
| )).thenReturn(EHR_EXTRACT_AVAILABILITY_DATETIME); |
There was a problem hiding this comment.
This is a bit of a smell, but not major.
adrianclay
reviewed
Aug 1, 2024
gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/ConditionMapperTest.java
Outdated
Show resolved
Hide resolved
adrianclay
reviewed
Aug 1, 2024
| @@ -367,8 +451,21 @@ private Bundle buildBundleWithStatementRefObservations() { | |||
| .setResource(new Observation().setId(STATEMENT_REF_ID_1))); | |||
| } | |||
|
|
|||
| private void assertConditionsMetaIsExpected(List<Condition> conditions, Meta expectedMeta) { | |||
| conditions.forEach(condition -> assertThat(condition.getMeta()).usingRecursiveComparison().isEqualTo(expectedMeta)); | |||
There was a problem hiding this comment.
I'd change this to be something like...
Suggested change
| conditions.forEach(condition -> assertThat(condition.getMeta()).usingRecursiveComparison().isEqualTo(expectedMeta)); | |
| assertAll(conditions.map(condition -> | |
| () -> assertThat(condition.getMeta()).usingRecursiveComparison().isEqualTo(expectedMeta) | |
| )); |
So we get the benefit of the assertAll
adrianclay
reviewed
Aug 1, 2024
gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/ConditionMapperTest.java
Outdated
Show resolved
Hide resolved
adrianclay
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR introduces the capability to handle
confidentialityCodesforConditions. The implementation checks if aLinksetorEhrCompositioncontains a confidentiality code with the valueNOPAT. If this code is present, meta security is added to the resource; otherwise, the code is ignored.Why
More details can be found on the ticket.
Type of change
Checklist: