Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Niad-3129 #733

Merged
merged 11 commits into from
Jul 31, 2024
Merged

Niad-3129 #733

merged 11 commits into from
Jul 31, 2024

Conversation

ole4ryb
Copy link
Contributor

@ole4ryb ole4ryb commented Jul 31, 2024 •
edited
Loading

What

Populate the "no disclosure to patient" label for ProcedureRequest

Why

This is part of a bigger picture change that is aimed to introduce "confidentialityCode" fiield to different PS Adaptor modules. This particular PR takes care of ProcedureRequest mapper.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users
  • A corresponding change has been made to the Mapping Documentation repository

@ole4ryb ole4ryb marked this pull request as ready for review July 31, 2024 13:04
@ole4ryb ole4ryb requested a review from martin-nhs July 31, 2024 13:05
martin-nhs
martin-nhs reviewed Jul 31, 2024
View reviewed changes
...anslator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/ProcedureRequestMapperTest.java Outdated
ENCOUNTERS,
PRACTISE_CODE);

assertNotNull(procedureRequest);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this assertion add any value? Likewise for the above tests! 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, probably not, I agree, will remove it

@martin-nhs martin-nhs enabled auto-merge (squash) July 31, 2024 15:21
@martin-nhs martin-nhs merged commit 005d839 into main Jul 31, 2024
1 check passed
@martin-nhs martin-nhs deleted the NIAD-3129 branch July 31, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-nhs martin-nhs martin-nhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ole4ryb @martin-nhs