NIAD-3128 #714

martin-nhs · 2024-07-22T10:33:05Z

What

This pull request enhances the functionality of MedicationRequestOrderMapper.java, MedicationRequestPlanMapper.java, and MedicationStatementMapper.java by introducing support for confidentiality codes. Specifically, it ensures that the meta.security attribute is populated for both MedicationRequest and MedicationStatement resources when a confidentiality code with the value NOPAT is present. This update improves the handling of sensitive information within these resources, aligning with privacy and security requirements.

Why

More details can be found on the ticket.

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

I have performed a self-review of my code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users
A corresponding change has been made to the Mapping Documentation repository

…r MedicationStatement's

…java

…anMapper.java

…vate

…st.java

MedicationRequestOrderMapperTest.java

…apperTest.java

…r.java

.../test/java/uk/nhs/adaptors/pss/translator/mapper/medication/MedicationRequestMapperTest.java

…tionRequestPlanMapper

…icationStatementMapper

…esentWithinMedicationStatement.xml

.../test/java/uk/nhs/adaptors/pss/translator/mapper/medication/MedicationRequestMapperTest.java

...t/java/uk/nhs/adaptors/pss/translator/mapper/medication/MedicationRequestPlanMapperTest.java

...nslator/src/test/java/uk/nhs/adaptors/pss/translator/service/ConfidentialityServiceTest.java

.../test/java/uk/nhs/adaptors/pss/translator/mapper/medication/MedicationRequestMapperTest.java

[NIAD-3128] Add unit tests to ConfidentialityServiceTest.java to cove…

e58c408

…r MedicationStatement's

martin-nhs marked this pull request as draft July 22, 2024 10:33

martin-nhs added 26 commits July 22, 2024 11:45

[NIAD-3128] Add failing unit test to MedicationRequestPlanMapperTest.…

f8f93de

…java

[NIAD-3128] Add failing unit test to MedicationRequestPlanMapperTest.…

c649824

…java

[NIAD-3128] Add failing unit test to MedicationRequestPlanMapperTest.…

3a0edc0

…java

[NIAD-3128] Add failing unit test to MedicationRequestPlanMapperTest.…

7e38010

…java

[NIAD-3128] Add failing unit test to MedicationRequestPlanMapperTest.…

2289d5f

…java

[NIAD-3128] Add logic to make unit tests pass for MedicationRequestPl…

ca1e9c9

…anMapper.java

[NIAD-3128] Remove unnecessary public access modifiers to package-pri…

15b04a4

…vate

[NIAD-3128] Refactorings

528420c

[NIAD-3128] Added failing unit test to MedicationRequestOrderMapperTe…

aa98771

…st.java

[NIAD-3128] Add logic to make MedicationRequestOrderMapper.java pass

da14567

[NIAD-3128] Add logic to make MedicationRequestOrderMapper.java pass

371ae17

[NIAD-3128] Enhance

8a22fa9

MedicationRequestOrderMapperTest.java

[NIAD-3128] DRY code up, removed unused logic

b22525f

[NIAD-3128] DRY code up, removed unused logic

e4d27c3

[NIAD-3128] Add logic to MedicationStatementMapper.java

e994153

[NIAD-3128] Enhance MedicationStatementMapperTest.java

975e964

[NIAD-3128] Enhance MedicationRequestOrderMapperTest

a0ee0d0

[NIAD-3128] Add test data

8ee8065

[NIAD-3128] Enhanced MedicationRequestPlanMapperTest.java

4131ee2

[NIAD-3128] Add custom NOPAT matcher, enhanced MedicationRequestPlanM…

06a57c0

…apperTest.java

[NIAD-3128] Refactored NopatMatcher.java

9c1fe0b

[NIAD-3128] Refactored NopatMatcher.java

c7b15cb

[NIAD-3128] Remove NopatMatcher.java in favor of OptionalCVCodeMatche…

0ceb56e

…r.java

[NIAD-3128] Enhance MedicationRequestPlanMapperTest.java

0da32b2

[NIAD-3128] Enhance MedicationRequestOrderMapperTest.java

de5ea25

[NIAD-3128] Enhance MedicationStatementMapperTest.java

c3463e1

martin-nhs marked this pull request as ready for review July 23, 2024 10:59

martin-nhs requested a review from adrianclay July 23, 2024 10:59

ole4ryb reviewed Jul 26, 2024

View reviewed changes

.../test/java/uk/nhs/adaptors/pss/translator/mapper/medication/MedicationRequestMapperTest.java Outdated Show resolved Hide resolved

ole4ryb reviewed Jul 26, 2024

View reviewed changes

.../test/java/uk/nhs/adaptors/pss/translator/mapper/medication/MedicationRequestMapperTest.java Outdated Show resolved Hide resolved

ole4ryb and others added 14 commits July 26, 2024 14:44

Merge branch 'main' into NIAD-3128

cdf372e

Merge branch 'main' into NIAD-3128

dcf7299

[NIAD-3128] Refactor MedicationRequestOrderMapperTest.java

251efe7

[NIAD-3128] Refactor MedicationRequestPlanMapperTest.java

d2710b3

[NIAD-3128] Added EhrComposition ConfidentialityCode logic to Medica…

24d4b5c

…tionRequestPlanMapper

[NIAD-3128] File rename

d1cd8eb

[NIAD-3128] Address checkstyle

6394e34

[NIAD-3128] Add ehrComposition -> confidentialityCode support for Med…

52a511b

…icationStatementMapper

[NIAD-3128] Add FileFactory and ehrExtract_nopatConfidentialityCodePr…

c6d84f3

…esentWithinMedicationStatement.xml

[NIAD-3128] Address PR comment #714 (comment)

4f741e4

[NIAD-3128] Address PR comment #714 (comment)

d0e255b

[NIAD-3128] Address PR comment #714 (comment)

51d8319

[NIAD-3128] Address failing test

c4f7079

[NIAD-3128] Address PR comment #714 (comment)

8babce0

martin-nhs enabled auto-merge (squash) July 30, 2024 12:50