Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Niad-3126: PS Adaptor ReferralRequest should support Organization reference types #697

Merged
merged 15 commits into from
Jul 16, 2024

Conversation

ole4ryb
Copy link
Contributor

@ole4ryb ole4ryb commented Jul 15, 2024

What

Added support for Organization reference types in ReferralRequest

Why

The referenced type (e.g. Organisation etc) should already be mapped from the AgentDirectory. In cases where the reference is an Organisation, it should be mapped as Organisation/{organisation-id} .

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users
  • A corresponding change has been made to the Mapping Documentation repository

@ole4ryb ole4ryb changed the title Niad-3126: PS Adaptor ReferralRequest should support different reference types Niad-3126: PS Adaptor ReferralRequest should support Organization reference types Jul 15, 2024
@ole4ryb ole4ryb marked this pull request as ready for review July 15, 2024 11:06
CHANGELOG.md Outdated
Please update / reload the SNOMED DB.
```

* Added support for Organization reference types in ReferralRequest.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this wasn't part of release 3.0.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, yeah, good point, it was a wrongly resolved merge conflict

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed now

@ole4ryb ole4ryb requested a review from adrianclay July 15, 2024 16:15
@ole4ryb ole4ryb merged commit 4bfc940 into main Jul 16, 2024
1 check passed
@ole4ryb ole4ryb deleted the NIAD-3126 branch July 16, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants