-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAID-3122 - Add confidentialityCode
support to AllergyIntoleranceMapper.java
#684
Conversation
confidentialityCode
support to AllergyIntoleranceMapper.java
@@ -88,14 +92,18 @@ private AllergyIntolerance mapAllergyIntolerance(RCMRMT030101UKEhrComposition eh | |||
.getId() | |||
.getRoot(); | |||
|
|||
final Meta meta = CONFIDENTIALITY_CODE_PRESENT.test(observationStatement) ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this refactoring won't be the most desirable once we've implemented a few of these mappers, but given my mindset of refactoring when the duplication is indeed visible and a problem, let's leave it as it is for now.
import java.util.Optional; | ||
|
||
public final class ConfidentialityUtil { | ||
private ConfidentialityUtil() { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to break a line after line 11 otherwise it is very difficult to read such a class.
Also, it would be good to have a line break between the constructor and the static variable.
What
Given the following XML which is parsed by the
AllergyIntolleranceMapper
:When the element is mapped, then expect the bundle to contain:
Why
Please include details of the reasoning for these changes
Type of change
Checklist: