[NIAD-2988] Lowercase Conversation ID for getMigrationRequest() #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianclay
reviewed
Jun 24, 2024
| @@ -26,7 +26,7 @@ public class AcknowledgeRecordService { | |||
| public Boolean handleAcknowledgeRecord( | |||
| @NotNull @NotEmpty String conversationId, | |||
| @NotNull @NotEmpty String confirmationResponseString) { | |||
| var patientMigrationRequest = patientMigrationRequestDao.getMigrationRequest(conversationId); | |||
| var patientMigrationRequest = patientMigrationRequestDao.getMigrationRequest(conversationId.toLowerCase()); | |||
There was a problem hiding this comment.
Hmm, strange as I'm pretty sure we're uppercasing the conversation ID when it's inserted.
There was a problem hiding this comment.
You're correct, my bad!
ole4ryb
reviewed
Jun 25, 2024
| @@ -138,9 +152,20 @@ public void sendAcknowledgeRequestWithMissingConfirmationResponseHeader() throws | |||
| .andExpect(content().json(expectedResponseBody)); | |||
| } | |||
|
|
|||
| // Helper Methods | |||
There was a problem hiding this comment.
I think we don't need this comments as they a bit clutter it here, the method is simple and it is very easy to see that it is a preparing/helper method for the test.
ole4ryb
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Previously:
/$gpc.ackendpoint.conversationIdwith a lowercase UUIDv4.Now:
/$gpc.ackendpoint.conversationIdwith a lowercase OR uppercase UUIDv4.Why
This bug could cause confusion and questions from NMEs as to why the endpoint doesn’t work.
Type of change
Checklist: