Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to check author date time exists to stop null pointer access. #548

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

azam145
Copy link
Contributor

@azam145 azam145 commented Mar 28, 2024

What

Please include a summary of the changes and the related issue

Why

Please include details of the reasoning for these changes

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [x ] I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users
  • A corresponding change has been made to the Mapping Documentation repository

@azam145 azam145 changed the title Need to check auther date time exists to stop null pointer access. Need to check author date time exists to stop null pointer access. Mar 28, 2024
@azam145 azam145 marked this pull request as ready for review March 28, 2024 14:32
@MartinWheelerMT MartinWheelerMT enabled auto-merge (squash) March 28, 2024 16:27
@MartinWheelerMT MartinWheelerMT merged commit 1387212 into main Mar 28, 2024
1 check passed
@MartinWheelerMT MartinWheelerMT deleted the NIAD-2773 branch March 28, 2024 16:27
@adrianclay
Copy link
Collaborator

@azam145 Functional changes without unit tests, raise my eyebrows. If we thought having this code is important, then it suggests that we should have some automated test confirming that this behaviour exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants