Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the process of fixing the integration tests a lot easier #526

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

adrianclay
Copy link
Collaborator

What

  • Regenerate the expected JSON files in the integration tests. This will make any future changes easier to view, as they won't have formatting changes in them too.
  • Consolidate the three "OVERWRITE" variables into one single variable.
  • Make the OVERWRITE variable actually overwrite the file.

Why

Should make development a lot easier.

Type of change

  • Internal change (non-breaking change with no effect on the functionality affecting end users)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users
  • A corresponding change has been made to the Mapping Documentation repository

@adrianclay adrianclay changed the title Fix integration tests overwrite file Make the process of fixing the integration tests a lot easier Mar 20, 2024
@adrianclay adrianclay enabled auto-merge (squash) March 20, 2024 15:23
@adrianclay adrianclay merged commit 31dc06b into main Mar 20, 2024
1 check passed
@adrianclay adrianclay deleted the fix-integrationTests-overwrite-file branch March 20, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants