Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIAD-2957: adding different practitioners to immunization #395

Merged
merged 8 commits into from
Jan 12, 2024
Merged

Conversation

ole4ryb
Copy link
Contributor

@ole4ryb ole4ryb commented Jan 8, 2024

What

Assigning role to a practitioner who records vaccinations.

Why

The roles of practitioners are not recorder in transfers hence it is difficult to identify who recorded a vaccination.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users
  • A corresponding change has been made to the Mapping Documentation repository

@ole4ryb ole4ryb marked this pull request as ready for review January 10, 2024 11:09
import java.util.stream.Collectors;

import io.micrometer.core.instrument.util.StringUtils;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong StringUtils, could you use the one from org.apache.commons.lang3 please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, good catch Martin. Will change it to the better apache commons library.

Copy link
Collaborator

@MartinWheelerMT MartinWheelerMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, other than StringUtil library

@ole4ryb ole4ryb merged commit 70cf006 into main Jan 12, 2024
1 check passed
@ole4ryb ole4ryb deleted the NIAD-2957 branch January 12, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants