NIAD-2843: Blood pressure NarrativeStatements are also mapped as Observation comments, leading to duplication #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not being mapped by the ObservationCommentMapper. Add new functionality to CompoundStatementResourceExtractors to exclude blood pressures when NarrativeStatements are being extracted
… not being mapped by the ObservationCommentMapper. Add source file for new test. Add new functionality to CompoundStatementResourceExtractors to exclude blood pressures when NarrativeStatements are being extracted.
…s://github.com/NHSDigital/nia-patient-switching-standard-adaptor into NIAD-2843-blood-pressure-note-being-duplicated
MartinWheelerMT
changed the title
adrianclay
reviewed
Nov 10, 2023
...r/src/main/java/uk/nhs/adaptors/pss/translator/util/CompoundStatementResourceExtractors.java
Outdated
Show resolved
Hide resolved
Refactor method in DocumentReferenceMapper to remove warning Add CHANGELOG.md
…s://github.com/NHSDigital/nia-patient-switching-standard-adaptor into NIAD-2843-blood-pressure-note-being-duplicated
ole4ryb
approved these changes
Nov 14, 2023
MartinWheelerMT
deleted the
NIAD-2843-blood-pressure-note-being-duplicated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updated functionality CompoundStatementResourceExtractors to exclude NarrativeStatements which are within blood pressures.
Added unit tests to ensure that the NarrativeStatement is not mapped by the ObservationCommentMapper when the statement is within a blood pressure.
Why
When mapping blood pressures, any NarrativeStatements are mapped to the comments element.
When the observationComment mapper then creates Observations for the NarrativeStatement, it includes those which have already been mapped by the blood pressure mapper. This leads to a duplication in the exported bundle.
Type of change
Please delete options that are not relevant.
Checklist: