-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIAD-2797: ReferralRequest priority should not use 'Stat' #365
Conversation
remove now unneeded source xml files
CHANGELOG.md
Outdated
@@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
|
|||
* Updated the way immunization codes are loaded to build these from the relationships reference set in the SNOMED CT | |||
release rather than the outdated CSV file. | |||
* Update ReferralRequest mapping to use `ASAP` instead of `Stat`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this is a breaking change 🤣 🤔.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can update to report as breaking change!
…m/NHSDigital/nia-patient-switching-standard-adaptor into NIAD-2797-referralRequestPriority
…m/NHSDigital/nia-patient-switching-standard-adaptor into NIAD-2797-referralRequestPriority
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enjoyed the assertAll
, tried playing with it locally and felt somewhat disappointed at verbose output JUnit produces. One day Java will learn what concise means.
What
Updated the Referral Request Mapper to use 'ASAP' instead of 'Stat' when mapping and add unit tests to cover these scenarios.
Have also refactored the tests for Referral Request Mapper and the mapper itself.
Why
As per the documentation: Request Priority we should be using 'stat' not 'asap' when mapping referral request priority codes.
Type of change
Please delete options that are not relevant.
Checklist: