Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIAD-2797: ReferralRequest priority should not use 'Stat' #365

Merged
merged 10 commits into from
Nov 8, 2023

Conversation

MartinWheelerMT
Copy link
Collaborator

@MartinWheelerMT MartinWheelerMT commented Nov 7, 2023

What

Updated the Referral Request Mapper to use 'ASAP' instead of 'Stat' when mapping and add unit tests to cover these scenarios.
Have also refactored the tests for Referral Request Mapper and the mapper itself.

Why

As per the documentation: Request Priority we should be using 'stat' not 'asap' when mapping referral request priority codes.

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users
  • A corresponding change has been made to the Mapping Documentation repository

@MartinWheelerMT MartinWheelerMT marked this pull request as ready for review November 7, 2023 18:10
CHANGELOG.md Outdated
@@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

* Updated the way immunization codes are loaded to build these from the relationships reference set in the SNOMED CT
release rather than the outdated CSV file.
* Update ReferralRequest mapping to use `ASAP` instead of `Stat`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is a breaking change 🤣 🤔.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can update to report as breaking change!

Copy link
Collaborator

@adrianclay adrianclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enjoyed the assertAll, tried playing with it locally and felt somewhat disappointed at verbose output JUnit produces. One day Java will learn what concise means.

@MartinWheelerMT MartinWheelerMT merged commit 2bd5349 into main Nov 8, 2023
1 check passed
@MartinWheelerMT MartinWheelerMT deleted the NIAD-2797-referralRequestPriority branch November 8, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants