NIAD-2908: bug fix - invalid state transition #346

benhession · 2023-10-27T15:14:31Z

What

Ignore acknowledgement messages for a migration that has entered a failed state.

The adapter can currently transition from a failed state to an in-progress state when an acknowledgment is received.

Please delete options that are not relevant.

I have performed a self-review of my code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users
A corresponding change has been made to the Mapping Documentation repository

...anslator/src/main/java/uk/nhs/adaptors/pss/translator/task/AcknowledgmentMessageHandler.java

adrianclay reviewed Oct 27, 2023

View reviewed changes

...anslator/src/main/java/uk/nhs/adaptors/pss/translator/task/AcknowledgmentMessageHandler.java Outdated Show resolved Hide resolved

adrianclay approved these changes Oct 30, 2023

View reviewed changes

benhession added 5 commits October 30, 2023 10:36

Ignore ack message if migration has failed.

c8e945e

Remove unnecessary switch case.

e93cf08

Update CHANGELOG.md

bf02af0

Checkstyle fixes

a7b59e4

Revert switch case removal following review

5e0d6b0

adrianclay force-pushed the NIAD-2908-bugfix-invalid-state-transition branch from ed22167 to 5e0d6b0 Compare October 30, 2023 10:36

benhession enabled auto-merge (squash) October 30, 2023 10:37

benhession merged commit ce3233c into main Oct 30, 2023

benhession deleted the NIAD-2908-bugfix-invalid-state-transition branch October 30, 2023 11:04