NIAD-2889: Bugfix - add additional JMS error handling #345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
If an exception is thrown with a null cause the handler itself throws an exception. This prevents the JMS message delivery count property from being updated and leads to the message being dequeued repeatedly.
The null pointer would also prevent any logging of the exception message. Therefore, in addition to handling an unexpected exception without a cause, extra logging has been added.
SQL statement logging had been setup during development but was not configurable to be used by the end user. When saving the inbound message, the logging statement placed the statement, including the entire message on the stack. Testing the service with a very low heap size (128 MB), this logging caused an out of memory error.
Type of change
Please delete options that are not relevant.
Checklist: