Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template improvement + Add jenkins timeout #338

Merged
merged 2 commits into from
Oct 20, 2023
Merged

PR template improvement + Add jenkins timeout #338

merged 2 commits into from
Oct 20, 2023

Conversation

adrianclay
Copy link
Collaborator

What

A couple of unrelated changes, but both small so bundled them.

Why

See commit messages for more details of each change.

Type of change

Please delete options that are not relevant.

  • Internal change (non-breaking change with no effect on the functionality affecting end users)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

If a build takes longer than an hour, then somethings gone wrong
and it's better to fail the build instead of pretending everything
is fine.
@adrianclay adrianclay merged commit 510a13d into main Oct 20, 2023
@adrianclay adrianclay deleted the smol-fixes branch October 20, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants