NIAD-2853: Fixed issue with coding text being set from incorrect place when mapping allergy intolerances #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is present) when populating the text of the codeable concept Add unit test to ensure correct mapping Add snomed codes system to the codeable concepts in the unit tests for accuracy Add xml source file for unit test Update payload_part.xml to include new test case and removed confusing incorrect data which was already present Update expectedBundle.json to reflect the changes made
Very confusing title, I think Medicus is only incidentally involved here. I much prefer the text in the CHANGELOG.md "Fixed issue with coding text being set from incorrect place when mapping allergy intolerances." |
adrianclay
reviewed
Oct 4, 2023
...translator/src/main/java/uk/nhs/adaptors/pss/translator/mapper/AllergyIntoleranceMapper.java
Show resolved
Hide resolved
adrianclay
reviewed
Oct 4, 2023
...r/src/test/resources/xml/AllergyIntolerance/allergy-structure-with-original-text-in-code.xml
Show resolved
Hide resolved
Add identifier ids to ignoreList in EhrExtractHandlingIT
MartinWheelerMT
changed the title
…he changes made for the UK06 test
benhession
reviewed
Oct 12, 2023
There was a problem hiding this comment.
Does the mapping documentation need updating with this change?
...translator/src/main/java/uk/nhs/adaptors/pss/translator/mapper/AllergyIntoleranceMapper.java
Outdated
Show resolved
Hide resolved
benhession
approved these changes
Oct 16, 2023
MartinWheelerMT
deleted the
NIAD-2853-unexpected-allergy-text-displayed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This code change is to make the allergy intolerance mapper use the
displayNameof the block when setting the value forcode.text.It also fixes some bad data in the related test data for the EhrExtractHandlingIT tests and introduces an additional unit test.
Why
This issue was raised by under NIAD-2853 and will provide more relevant content when the Json Bundle is used by the consumer
Type of change
Please delete options that are not relevant.
Checklist: