Add MQ section to OPERATING.md #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhession
reviewed
Oct 3, 2023
OPERATING.md
Outdated
| **Using AmazonMQ** | ||
|
|
||
| * A persistent broker (not in-memory) must be used to avoid data loss. | ||
| * A configuration profile that includes settings for [retry and dead-lettering](https://activemq.apache.org/message-redelivery-and-dlq-handling.html) must be applied. |
There was a problem hiding this comment.
I think we should add "and placing non persistent messages onto the dead letter queue" should be added here too. As MHS adaptor currently sends them non-persistent dead lettering wouldn't be used without this config.
adrianclay
force-pushed
the
NIAD-2783
branch
2 times, most recently
from
b925541 to
5b649d4
Compare
The content has been plagiarised from the GP2GP adaptor
Also document broker related environment variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content has been plagiarised from the GP2GP adaptor.
I'm not clear if there's anything more to add for now, so happy to take a steer from @benhession.