NIAD-2846: new RCMR_IN030000UK07 compatibility test #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
September 28, 2023 13:42
ole4ryb
changed the title
adrianclay
reviewed
Oct 4, 2023
...translator/src/integrationTest/java/uk/nhs/adaptors/pss/translator/EhrExtractHandlingIT.java
Show resolved
Hide resolved
adrianclay
reviewed
Oct 4, 2023
...translator/src/integrationTest/java/uk/nhs/adaptors/pss/translator/EhrExtractHandlingIT.java
Outdated
Show resolved
Hide resolved
adrianclay
reviewed
Oct 4, 2023
...p-translator/src/main/java/uk/nhs/adaptors/pss/translator/task/EhrExtractMessageHandler.java
Outdated
Show resolved
Hide resolved
adrianclay
reviewed
Oct 4, 2023
gp2gp-translator/src/main/java/uk/nhs/adaptors/pss/translator/util/ObservationUtil.java
Outdated
Show resolved
Hide resolved
adrianclay
reviewed
Oct 4, 2023
adrianclay
reviewed
Oct 4, 2023
adrianclay
reviewed
Oct 4, 2023
| private RCMRMT030101UK04EhrFolder getEhrFolder(RCMRIN030000UK06Message xmlMessage) { | ||
| return xmlMessage.getControlActEvent().getSubject().getEhrExtract().getComponent().get(0).getEhrFolder(); | ||
| private RCMRMT030101UK04EhrFolder getEhrFolder(RCMRIN030000UKMessage xmlMessage) { | ||
| if (xmlMessage instanceof RCMRIN030000UK07Message) { |
There was a problem hiding this comment.
What's the plan for this if statements (and others), they look a bit grim are them temprary?
adrianclay
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding an additional test to make sure that existing codebase can handle RCMR_IN030000UK07 xml type
Why
The current implementation works with RCMR_IN030000UK06 xml type. The change adds a new test to make sure that the current codebase can handle RCMR_IN030000UK07 type without any errors.
Checklist: