Skip to content

Commit

Permalink
add common qc
Browse files Browse the repository at this point in the history
  • Loading branch information
anthony-nhs committed Dec 12, 2024
1 parent fdb1d37 commit c82c2da
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 6 deletions.
1 change: 1 addition & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
}
}
},
"remoteEnv": { "LOCAL_WORKSPACE_FOLDER": "${localWorkspaceFolder}" },
"postCreateCommand": "rm -f ~/.docker/config.json; git config --global --add safe.directory /workspaces/electronic-prescription-service-get-secrets; make install; direnv allow ."
// "features": {},
// Use 'forwardPorts' to make a list of ports inside the container available locally.
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,13 @@ on:
required: true

jobs:
quality_checks:
uses: NHSDigital/eps-workflow-quality-checks/.github/workflows/[email protected]
secrets:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
build:
runs-on: ubuntu-latest
needs: quality_checks
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down Expand Up @@ -42,12 +47,6 @@ jobs:
run: |
make install
- name: run check-licenses
run: make check-licenses

- name: run lint
run: make lint

- name: run compile-go
run: make compile-go

Expand Down
10 changes: 10 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,15 @@ repos:
types_or: [yaml]
pass_filenames: false

- repo: local
hooks:
- id: git-secrets
name: Git Secrets
description: git-secrets scans commits, commit messages, and --no-ff merges to prevent adding secrets into your git repositories.
entry: bash
args:
- -c
- 'docker run -v "$LOCAL_WORKSPACE_FOLDER:/src" git-secrets --pre_commit_hook'
language: system
fail_fast: true
default_stages: [commit]

0 comments on commit c82c2da

Please sign in to comment.