Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERSSUP-65227]-[]-[Initial A and G examples]-[DMW] #597

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

nhsd-david-wass
Copy link
Contributor

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

"url": "https://fhir.nhs.uk/StructureDefinition/Extension-ERS-Referral",
"extension": [
{
"url": "sourceSystem",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per here, I would also question if this is needed.

]
},
"priority": "routine",
"intent": "order",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there is a question Question for this already. I agree we should check again. Although "order" was picked when we discussed in the context of Patient Care APIs

"url": "state",
"valueCoding": {
"system": "https://fhir.nhs.uk/CodeSystem/eRS-ReferralState",
"code": "INCOMPLETE",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casing. Agreed we should check Question.

This one already exists in simplifier though as we created for Patient Care.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Patient care, this is "https://fhir.nhs.uk/StructureDefinition/Extension-eRS-ServiceRequest-State"
should the url be consistent across the two systems?

"system": "https://fhir.nhs.uk/Id/ods-organization-code",
"value": "C81007"
},
"display": "VERNON STREET MEDICAL CTR"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to make a decision on display values.

For resources we don't expose ourselves (like Organisation/Practitioner) I'm more open to this as a shortcut. But for those we do expose it would be better if they hit the API (i.e. GET HealthcareService)

}
],
"requester": {
"reference": "#requester"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RE https://nhsd-confluence.digital.nhs.uk/pages/viewpage.action?spaceKey=ES&title=High+Level+Data+Items+Required

It seems like the business are still deciding what to return here. Not clear if we would have to return details about obo in addition.

"coding": [
{
"system": "https://fhir.nhs.uk/CodeSystem/message-category-servicerequest",
"code": "referral"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be request?

"coding": [
{
"system": "https://fhir.nhs.uk/CodeSystem/message-category-servicerequest",
"code": "referral"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be request?

]
}
],
"identifier": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yes as this is server assigned it just comes back in the response.

Actually for a conversion it would be pulled through from the linked A&G request too.

"questionnaire": "https://fhir.nhs.uk/Questionnaire/ERS-ShortList",
"basedOn": [
{
"reference": "ServiceRequest/a.832db7fa-ebdd-44b6-ab3b-8329c2d43149/_history/5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we have a question about including the version here already.

I suspect we may need this for optimistic locking. We can't escape that the shortlist is a sub-resource of the referral really.

Certainly the reference type does allow it http://hl7.org/fhir/R4/references-definitions.html#Reference.reference

}
],
"subject": {
"identifier": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly probably don't need this here. But we could include.

"linkId": "searchCriteria",
"answer": [
{
"valueString": "HealthcareService?supportedSpecialty=general-medicine&supportedPriority=routine"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the Question we will need to look closer at service search to see if we can do it restfully like this. It would be nice if we could to avoid an operation.

}
},
{
"valueReference": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently e-RS effectively only supports a single service on the shortlist. We should probably keep the examples aligned with this.

(I have heard talk about allowing multiple services in the conversation so we should keep the flexibility of having the shortlist for A&G)

]
}
],
"source": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice there is a slot for who answered the question (i.e. who created the shortlist). Have the business asked for this?

I notice it isn't in the request. Probably does makes sense for the server to fill this .

"reference": "ServiceRequest/a.832db7fa-ebdd-44b6-ab3b-8329c2d43149"
}
],
"subject": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again probably redundant but could include.

],
"note": [
{
"text": "Please advise me on this patient who ...(information about patient)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RE Question

Looking at the documentation on "note":

Additional notes or commentary about the communication by the sender, receiver or other interested parties.

This make it sound like it is notes about the message rather than the note is the message. So potentially the payload.contentString is a better fit.

"coding": [
{
"system": "https://fhir.nhs.uk/CodeSystem/message-category-servicerequest",
"code": "referral"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be request?

"url": "state",
"valueCoding": {
"system": "https://fhir.nhs.uk/R4/CodeSystem/eRS-ReferralState-1",
"code": "ACTIVE", ( do we need to mirror the ers states ( like AWAITING_RESPONSE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is the defining state.

"requester": {
"reference": "#requester"
},
"supportingInfo": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I like the forward references here. Then you don't have to go searching for things related to this ServiceRequest.

@nhsd-david-wass nhsd-david-wass force-pushed the feature/ERSSUP-65227 branch 2 times, most recently from 2a73645 to 3a54223 Compare December 7, 2022 15:55
@nhsd-david-wass
Copy link
Contributor Author

/azp run

1 similar comment
@nhsd-david-wass
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nhsd-david-wass nhsd-david-wass force-pushed the feature/ERSSUP-65227 branch 2 times, most recently from cce58fd to e31f43f Compare December 13, 2022 14:33
@nhsd-david-wass
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nhsd-david-wass
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nhsd-david-wass
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nhsd-david-wass
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nhsd-david-wass
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nhsd-david-wass nhsd-david-wass force-pushed the feature/ERSSUP-65227 branch 5 times, most recently from cb0a03e to f90d7f3 Compare December 22, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants