Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ERSSUP-62939]-[]-[Extra tests for access-mode header being overwritt… #462

Merged
merged 1 commit into from
Nov 2, 2022
Merged

[ERSSUP-62939]-[]-[Extra tests for access-mode header being overwritt… #462

merged 1 commit into from
Nov 2, 2022

Conversation

jamiegreen4
Copy link
Contributor

…en]-[JG]

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@jamiegreen4 jamiegreen4 force-pushed the feature/ERSSUP-62939 branch 3 times, most recently from 7106269 to ea03009 Compare September 28, 2022 07:21
@jamiegreen4 jamiegreen4 force-pushed the feature/ERSSUP-62939 branch 2 times, most recently from e556ffd to b4a823d Compare October 14, 2022 07:23
@strutt strutt added the dependencies Pull requests that update a dependency file label Oct 28, 2022
RajaGovindharaj16
RajaGovindharaj16 reviewed Oct 28, 2022
View reviewed changes
Copy link
Contributor

@RajaGovindharaj16 RajaGovindharaj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

@jamiegreen4 jamiegreen4 merged commit 9c9dcdc into develop Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RajaGovindharaj16 RajaGovindharaj16 RajaGovindharaj16 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamiegreen4 @RajaGovindharaj16 @strutt @greenjamie