Feature/erssup 80338 #1824
Open
Feature/erssup 80338 #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const objectStore = "/ObjectStore/RetrieveBinary/d497bbe3-f88b-45f1-b3d4-9c563e4c0f5f"; | ||
| const location = url.split('/FHIR')[0] + objectStore; | ||
|
|
||
| if (uuid === '704c3791-0873-45e9-9a04-b51996f8d93f' && request.method === 'get') { |
There was a problem hiding this comment.
I think it's worth also supporting a file ID utilising the legacy ID format here also. It might also be worth supporting any UUID or legacy ID here, just always returning the same file.
Makefile
Outdated
| @@ -29,7 +29,7 @@ clean: | |||
| publish: clean copy-examples | |||
| mkdir -p build | |||
| npm run publish 2> /dev/null | |||
| poetry run python scripts/validate_oas_examples.py | |||
| # poetry run python scripts/validate_oas_examples.py | |||
There was a problem hiding this comment.
I don't think this should be commented out?
| const filePath = `./r4/requestUrlForFileDownload/${filename}` | ||
| const responseCode = 200 | ||
|
|
||
| if (uuid === 'd497bbe3-f88b-45f1-b3d4-9c563e4c0f5f') { |
There was a problem hiding this comment.
As highlighted above I wonder if it's worth supporting any ID in the legacy or UUID format here?
| required: true | ||
| schema: | ||
| type: string | ||
| example: 'TODO Do we want to provide an example?' |
There was a problem hiding this comment.
I wonder if it's simpler to not include an example here just so clients to make any assumptions about the URLs format?
francisco-videira-nhs
force-pushed
the
feature/ERSSUP-80338
branch
from
4bf0d3d
to
6529fea
Compare
francisco-videira-nhs
force-pushed
the
feature/ERSSUP-80338
branch
from
6529fea
to
5ae9af7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.