re-adding changes after erroneous git rebase #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A new St Georges importer has been written to account for a new data format (see planio ticket 36213).
Why?
A new importer had to be created to be able to parse St Georges colorectal data.
How?
The importer was written based on the rules sent by Fiona.
Testing?
Unittests have been written. A QA of the variant counts has also been completed and signed off by Fiona.
Note: git commit history for the work can be found in branch feature/36213/st_georges_crc_importer, this original branch was created from the 'main' branch in error, instead of the 'develop' branch. Code has been copied across to this new branch forked from 'develop'.