Fixed bug for missing organisational_testresult #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code changes look good to me- have you checked the counts are the same before and after? |
Yes , that I have checked ✅ |
lauramccluskey1
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Some of the Bristol records were missing ORGANISATIONCODE_TESTRESULT . More details on Jira #2056
Why?
Genotype duplication logic was wrong and rather duplicating a new genotype, it was being created from raw record and hence was loosing on the properties already set.
How?
Logic has been rightly applied for duplicating genotype and also code has been restructured.
Test?
select * from molecular_data where organisationcode_testresult is null;gives 0 rows now.