make changes from code review

NHSDigital · Jan 29, 2024 · d4d9719 · d4d9719
1 parent 42a1ef3
commit d4d9719
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/import/brca/providers/oxford/oxford_handler.rb b/lib/import/brca/providers/oxford/oxford_handler.rb
@@ -27,7 +27,7 @@ def process_fields(record)
 
           def brca_file?
             file_name = @batch.original_filename
-            file_path = file_name.slice(0, file_name.rindex('/'))
+            file_path = File.dirname(file_name)
             file_path_array = file_name.split('/')
             pseudo_file = file_path_array[file_path_array.length - 1]
             pseudo_filename = pseudo_file.sub(/.xls[x]?.pseudo/, '')

diff --git a/lib/import/colorectal/providers/oxford/oxford_handler_colorectal.rb b/lib/import/colorectal/providers/oxford/oxford_handler_colorectal.rb
@@ -26,7 +26,7 @@ def process_fields(record)
 
           def colorectal_file?
             file_name = @batch.original_filename
-            file_path = file_name.slice(0, file_name.rindex('/'))
+            file_path = File.dirname(file_name)
             file_path_array = file_name.split('/')
             pseudo_file = file_path_array[file_path_array.length - 1]
             pseudo_filename = pseudo_file.sub(/.xls[x]?.pseudo/, '')