Fix error when passing a boolean mask #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing a boolean mask to `add_modality` (which is supported according to the type hints) using
```python
mask = np.zeros((3000, 3000), dtype="uint8")
mask [ 500:-500, 20:-500] = 1
```
It failed with
```pytb
File <redacted>/python3.10/site-packages/wsireg/reg_images/tifffile_reg_image.py:46, in TiffFileRegImage.__init__(self, image_fp, image_res, mask, pre_reg_transforms, preprocessing, channel_names, channel_colors)
42 self._get_dim_info()
44 self._dask_image = self._get_dask_image()
---> 46 if mask:
47 self._mask = self.read_mask(mask)
49 self.pre_reg_transforms = pre_reg_transforms
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
```
The fix is simple: check `if mask is None:` instead of `if mask:`.
|
Thanks for this fix, after it builds I will merge and bump version so it deploys to pip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing a boolean mask to
add_modality(which is supported according to the type hints) usingIt failed with
File <redacted>/python3.10/site-packages/wsireg/reg_images/tifffile_reg_image.py:46, in TiffFileRegImage.__init__(self, image_fp, image_res, mask, pre_reg_transforms, preprocessing, channel_names, channel_colors) 42 self._get_dim_info() 44 self._dask_image = self._get_dask_image() ---> 46 if mask: 47 self._mask = self.read_mask(mask) 49 self.pre_reg_transforms = pre_reg_transforms ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()The fix is simple: check
if mask is None:instead ofif mask:.