Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually reinstating ai_min after test failure #739

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

glemieux
Copy link
Contributor

@glemieux glemieux commented Apr 16, 2021

Reinstating ai_min that was removed in PR #733 as it appears to be causing test failures.

Description:

During testing of PR #734 and it's accompanying CTSM PR #1324 it was discovered that merging in fates tag sci.1.43.6_api.14.2.0 into the snow occlusion fates PR branch was causing failures on the following aux_clm tests:

SMS_D_Lm6.f45_f45_mg37.I2000Clm45Fates.cheyenne_intel.clm-FatesColdDef
SMS_D_Lm6.f45_f45_mg37.I2000Clm50Fates.cheyenne_intel.clm-FatesColdDef
SMS_D_Lm6_P144x1.f45_f45_mg37.I2000Clm50Fates.cheyenne_intel.clm-FatesColdDef

Collaborators:

@rgknox @ekluzek @billsacks

Expectation of Answer Changes:

This will change answers relative to the last tag.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

All the above tests pass now when merged into #734.

Testing of fates and aux_clm suite without #734 in progress.

CTSM (or) E3SM (specify which) test hash-tag:
See below for regression test details

CTSM (or) E3SM (specify which) baseline hash-tag:
See below for regression test details

FATES baseline hash-tag:
See below for regression test details

Test Output:
ctsm5.1.dev033 merged into pr branch and this pr branch merged onto #734:
SMS_D_Lm6.f45_f45_mg37.I2000Clm50Fates.cheyenne_intel.clm-FatesColdDef:
/glade/u/home/glemieux/scratch/tests_0416-103437ch

SMS_D_Lm6.f45_f45_mg37.I2000Clm50Fates.cheyenne_intel.clm-FatesColdDef:
/glade/u/home/glemieux/scratch/tests_0416-162804ch

SMS_D_Lm6_P144x1.f45_f45_mg37.I2000Clm50Fates.cheyenne_intel.clm-FatesColdDef:
/glade/u/home/glemieux/scratch/tests_0416-162822ch

See below for regression test details

@glemieux
Copy link
Contributor Author

glemieux commented Apr 16, 2021

I ran fates test suite baseline comparison against fates-sci.1.44.0_api.14.2.0-ctsm5.1.dev025-C2094348b-F74433f48 and generated new baselines for this branch using ctsm5.1.dev033: /glade/u/home/glemieux/scratch/tests_0416-134459ch. All expected tests PASS although not all b4b (which is not unexpected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants